Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

fix: refactor storage template #18

Merged
merged 5 commits into from
Dec 25, 2019
Merged

fix: refactor storage template #18

merged 5 commits into from
Dec 25, 2019

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Dec 23, 2019

It improve the shape of the storage plugin

  • add more informative types
  • add example as comments
  • add missing methods (as tokens)
  • update types

@DanielRuf DanielRuf changed the title fix: refactorstorage template fix: refactor storage template Dec 24, 2019
@juanpicado juanpicado marked this pull request as ready for review December 25, 2019 11:33
@@ -19,7 +19,7 @@
"@typescript-eslint/eslint-plugin": "^2.12.0",
"@verdaccio/babel-preset": "^8.5.0",
"@verdaccio/eslint-config": "^8.5.0",
"@verdaccio/types": "^8.5.0",
"@verdaccio/types": "^8.5.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick 🚀

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@juanpicado juanpicado merged commit 19b609a into master Dec 25, 2019
@juanpicado juanpicado deleted the fix-storage-template branch December 25, 2019 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants